Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-3265 Fix double scrolling composer #3280

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tddang-linagora
Copy link
Contributor

Issue

Dependency

Resolved

Screen.Recording.2024-11-18.at.16.04.51.mov

@dab246
Copy link
Member

dab246 commented Nov 18, 2024

  • We should test it on Linux or Windows machine because on Mac currently no such error occurs

@tddang-linagora
Copy link
Contributor Author

We should test it on Linux or Windows machine because on Mac currently no such error occurs

This is recorded on MacOS

Screen.Recording.2024-11-19.at.10.14.32.mov

@dab246
Copy link
Member

dab246 commented Nov 19, 2024

We should test it on Linux or Windows machine because on Mac currently no such error occurs

This is recorded on MacOS

Screen.Recording.2024-11-19.at.10.14.32.mov

Is this recorde test on Firefox browser? So, Please add demo after fix with this browser.

@tddang-linagora
Copy link
Contributor Author

Please add demo after fix with this browser.

Screen.Recording.2024-11-19.at.13.50.43.mov

dab246
dab246 previously approved these changes Nov 19, 2024
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dab246
Copy link
Member

dab246 commented Nov 20, 2024

  • Double scrollbar is gone but cursor disappears when entering a new line
error.mov

On prod: tmail.linagora.com it still work well:

Screen.Recording.2024-11-20.at.10.34.09.mov

Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Check build failed on CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants