Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-1774: Update avatar when have changes #1953

Closed
wants to merge 6 commits into from

Conversation

sherlockvn
Copy link
Contributor

Ticket

#1774

Root cause

If this is a bug, please provide a brief description of the root cause of the issue

Solution

Outline the implemented solution, detailing the changes made and how they address the issue

Impact description

If this is not a bug, please explain how the changes affect the project

Test recommendations

Recommendations for how to test this, or anything else you are worried about?

Pre-merge

Does anything else need to be done before merging?

Resolved

Attach screenshots or videos demonstrating the changes

  • Web:
Screen.Recording.2024-07-16.at.16.21.51.mov
  • Android:
  • IOS:

Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1953

@sherlockvn sherlockvn force-pushed the TW-1774/update-avatar-when-have-changes branch from 83c5f32 to b54ea4e Compare July 22, 2024 05:26
@nqhhdev
Copy link
Member

nqhhdev commented Jul 22, 2024

Pls resolve conflicts.

@Te-Z
Copy link
Contributor

Te-Z commented Jul 24, 2024

Tested on android and chrome. LGTM

@nqhhdev
Copy link
Member

nqhhdev commented Jul 25, 2024

  • ❌ Remove avatar not work
Screenshot 2024-07-25 at 10 02 43

@nqhhdev nqhhdev changed the title Tw 1774/update avatar when have changes TW-1774: Update avatar when have changes Jul 25, 2024
@sherlockvn
Copy link
Contributor Author

  • ❌ Remove avatar not work
Screenshot 2024-07-25 at 10 02 43
1111.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants