Tw 1774/update avatar when have changes solution 2 #2021
Closed
+468
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherlockvn
requested review from
hoangdat,
dab246,
nqhhdev,
hieutbui,
tddang-linagora and
Te-Z
as code owners
|
Pls check format code 
|
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/2021 |
|
Still run test failed, pls check it 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Related issue
#1774
Solution:
We continue to use
SyncUpdateto update the avatars in the chat list. However, instead of discarding additionalSyncUpdateevents in the rateLimit function, we now combine the relevant information from these updates to retrieve the most recentavatarUrl.Demo web:
Screen.Recording.2024-09-12.at.12.29.30.PM.mov