Removed "add player by name"

Changelog.lua

@@ -6,6 +6,9 @@ Namespace.Changelog = {
         features = {
             'Added a preferred icon for player configuration. When configured and you get lead, the player will be marked with the selected icon, or get another available icon if available. Players with a preferred icon will take precedence over players with "any available icon"',
         },
+        improvements = {
+            'Removed "add player by name" for now, as it was limited to the combination of the other two ways of adding users'
+        },
     },
     {
         version = '10.0.2-13',
@@ -69,60 +72,60 @@ Namespace.Changelog = {
             'Added a toggle to control automatic promotion and demotion behavior',
         },
     },
-    {
-        version = '10.0.0-5',
-        features = {
-            'Added an option to mark yourself with an icon when you become lead',
-            'Added an option to play a sound when you are promoted to, or demoted from lead',
-            'Added a ready check sound and taskbar flash when the popup to give lead is shown',
-            'Added a changelog inside the addon',
-            'Added an option to automatically promote members to assistant. Target a player and run /bgca in chat to add them to the list. You can also manually add players in the "Battleground Tools -> Leader Setup -> Decision Automation" section',
-        },
-        improvements = {
-            'Internal rework to detect when someone in the raid becomes member, assistant, or lead, to improve accuracy for automation tools',
-            'Some minor performance improvements when the addon tries to find the current raid leader, or a specific unit (like player, raid5, party2 etc)',
-            'Reworked the options ui to utilize the space more efficiently',
-            'Names in the accept/reject lead input, and the automatic assistant input, are now sorted'
-        },
-        bugs = {
-            'Fixed an issue where requesting lead would miss when lead was given without the raid roster changing',
-        },
-    },
-    {
-        version = '10.0.0-4',
-        improvements = {
-            'Updated Russian translations (by k33th)',
-            'Nicer messages when text is being printed to the chat',
-        },
-    },
-    {
-        version = '10.0.0-3',
-        features = {
-            'Added Russian translations (by k33th)',
-        },
-        improvements = {
-            'Tweaked how often the leader would ask for lead in certain scenarios'
-        },
-        bugs = {
-            'Fixed an issue where the "give lead" window did not automatically close after giving lead',
-        },
-    },
-    {
-        version = '10.0.0-2',
-        improvements = {
-            'Removed some code that was bridging API changes between 9.2.7 and 10.0.0'
-        },
-        bugs = {
-            'Fixed an issue where the the "enter" button would not always properly update on cancel or enter messages',
-        },
-    },
-    {
-        version = '10.0.0-1',
-        improvements = {
-            'Changed versioning to <wow version>-<incremental bgc number> to better show which WoW client it works with',
-        },
-        bugs = {
-            'Fixed an incompatibility with the latest 10.0.0 version',
-        },
-    },
+    --{
+    --    version = '10.0.0-5',
+    --    features = {
+    --        'Added an option to mark yourself with an icon when you become lead',
+    --        'Added an option to play a sound when you are promoted to, or demoted from lead',
+    --        'Added a ready check sound and taskbar flash when the popup to give lead is shown',
+    --        'Added a changelog inside the addon',
+    --        'Added an option to automatically promote members to assistant. Target a player and run /bgca in chat to add them to the list. You can also manually add players in the "Battleground Tools -> Leader Setup -> Decision Automation" section',
+    --    },
+    --    improvements = {
+    --        'Internal rework to detect when someone in the raid becomes member, assistant, or lead, to improve accuracy for automation tools',
+    --        'Some minor performance improvements when the addon tries to find the current raid leader, or a specific unit (like player, raid5, party2 etc)',
+    --        'Reworked the options ui to utilize the space more efficiently',
+    --        'Names in the accept/reject lead input, and the automatic assistant input, are now sorted'
+    --    },
+    --    bugs = {
+    --        'Fixed an issue where requesting lead would miss when lead was given without the raid roster changing',
+    --    },
+    --},
+    --{
+    --    version = '10.0.0-4',
+    --    improvements = {
+    --        'Updated Russian translations (by k33th)',
+    --        'Nicer messages when text is being printed to the chat',
+    --    },
+    --},
+    --{
+    --    version = '10.0.0-3',
+    --    features = {
+    --        'Added Russian translations (by k33th)',
+    --    },
+    --    improvements = {
+    --        'Tweaked how often the leader would ask for lead in certain scenarios'
+    --    },
+    --    bugs = {
+    --        'Fixed an issue where the "give lead" window did not automatically close after giving lead',
+    --    },
+    --},
+    --{
+    --    version = '10.0.0-2',
+    --    improvements = {
+    --        'Removed some code that was bridging API changes between 9.2.7 and 10.0.0'
+    --    },
+    --    bugs = {
+    --        'Fixed an issue where the the "enter" button would not always properly update on cancel or enter messages',
+    --    },
+    --},
+    --{
+    --    version = '10.0.0-1',
+    --    improvements = {
+    --        'Changed versioning to <wow version>-<incremental bgc number> to better show which WoW client it works with',
+    --    },
+    --    bugs = {
+    --        'Fixed an incompatibility with the latest 10.0.0 version',
+    --    },
+    --},
 }

Config.lua

@@ -684,14 +684,6 @@ function Namespace.Config.GetConfigurationSetup()
                                 set = addPlayerConfig,
                                 order = 2,
                             },
-                            addPlayerInput = {
-                                name = L['Add player by name'],
-                                type = 'input',
-                                width = 1.2,
-                                get = function () end,
-                                set = addPlayerConfig,
-                                order = 3,
-                            },
                         }
                     }
                 },

PlayerData.lua

@@ -201,7 +201,7 @@ function Namespace.PlayerData.RebuildPlayerData()
                     name = GetRealUnitName(unit),
                     readyState = ReadyCheckState.Nothing,
                     deserterExpiry = -1,
-                    units = {primary = unit, [unit] = true},
+                    units = { primary = unit, [unit] = true },
                     battlegroundStatus = BattlegroundStatus.Nothing,
                     roleCheckStatus = RoleCheckStatus.Nothing,
                     isConnected = UnitIsConnected(unit),