Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ASV benchmark workflow on PR #1

Merged
merged 12 commits into from
Jul 31, 2023
Merged

Test ASV benchmark workflow on PR #1

merged 12 commits into from
Jul 31, 2023

Conversation

camposandro
Copy link
Collaborator

Tests if the Github workflow that runs the ASV benchmarks posts a comment about the performance on the PR.

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link
Contributor

Before After Ratio Method
[fcd6c97] [5c42158]
<main>
failed 300±0.01ms n/a benchmarks.TimeSuite.time_iterkeys
6.91±0.04μs 200±0.03ms 28972.80 benchmarks.TimeSuite.time_keys
30.5±0.2μs 501±0.03ms 16415.03 benchmarks.TimeSuite.time_range
failed 1.00±0s n/a benchmarks.TimeSuite.time_xrange

@github-actions
Copy link
Contributor

Before After Ratio Method
[fcd6c97] [62761e8]
failed 300±0.01ms n/a benchmarks.TimeSuite.time_iterkeys
5.78±0.04μs 200±0.02ms 34668.66 benchmarks.TimeSuite.time_keys
25.2±0.07μs 501±0.02ms 19830.96 benchmarks.TimeSuite.time_range
failed 1.00±0s n/a benchmarks.TimeSuite.time_xrange

@camposandro camposandro merged commit 068b45c into main Jul 31, 2023
1 check passed
@camposandro camposandro deleted the test-pr branch January 11, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant