Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - introducing tensorboard to fibad #119

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

drewoldag
Copy link
Collaborator

@drewoldag drewoldag commented Nov 13, 2024

WIP

The first attempt is using pytorch ignite's built in tensorboard handler for emitting metrics to be consumed by tensorboard. It's not clear if this by itself will be sufficient.

It does seem that tensorboardX is meant to be more generally usable beyond pytorch and tensorboard, so perhaps that will be the way to go forward. But for now, we're just getting the scaffolding in place.

Screenshot 2024-11-12 at 4 14 41 PM

@drewoldag drewoldag self-assigned this Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.46%. Comparing base (e666dbe) to head (879232a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fibad/pytorch_ignite.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
- Coverage   40.65%   40.46%   -0.19%     
==========================================
  Files          19       19              
  Lines        1075     1080       +5     
==========================================
  Hits          437      437              
- Misses        638      643       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 13, 2024

Before [4d878a9] After [edb44cb] Ratio Benchmark (Parameter)
2.50±0.9s 2.99±1s ~1.19 benchmarks.time_computation
1.81k 2.73k 1.51 benchmarks.mem_list

Click here to view all benchmarks.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant