Remove external_class as config parameter
#67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e` is a key the registry or a libpath.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 38.33% 37.60% -0.74%
==========================================
Files 17 17
Lines 720 734 +14
==========================================
Hits 276 276
- Misses 444 458 +14 ☔ View full report in Codecov by Sentry. |
mtauraso
reviewed
Sep 23, 2024
| @@ -27,22 +27,22 @@ def get_or_load_class(config: dict, registry: dict) -> type: | |||
| a `name` nor `external_cls` key was found in the config. | |||
| """ | |||
|
|
|||
| # User specifies one of the built in classes by name | |||
| #! Once we have confidence in the config having default values, we can remove this check | |||
| if "name" in config: | |||
| class_name = config.get("name") | |||
There was a problem hiding this comment.
Since the new config stuff went in you will probably have to make this config[name] to get it working again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
external_classas a config parameter, and checking ifnameis a key the registry or a libpath.In the case of an externally defined model and config file, if the user specified the external_class as the model to use, we would instead default to the model defined in the
namekey of thefibad_default_config.tomlfile. Clearly not what the user would expect.So for now, we allow
nametobe either a key into the registry dictionary or a libpath string for an external model class.This isn't quite where I would like it. There are plenty of exceptions raised, but it would be nice to add some simple logging as well.