Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to latest PPT version #79

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Updating to latest PPT version #79

merged 1 commit into from
Oct 1, 2024

Conversation

drewoldag
Copy link
Collaborator

No description provided.

@drewoldag drewoldag self-assigned this Oct 1, 2024
include_benchmarks: true
include_docs: true
include_notebooks: true
mypy_type_checking: none
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot of type annotations. Do we want to turn type checking on as a way to keep that habit?

(I ask not knowing if this does what I think it does or not 😄 )

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it could be a beneficial thing to do so. It will slow down committing code, but the value add might be appreciated by the end users. I'll create an issue for it.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.55%. Comparing base (d2048f7) to head (de69ff5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fibad/example_benchmarks.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   35.55%   35.55%           
=======================================
  Files          18       18           
  Lines         869      869           
=======================================
  Hits          309      309           
  Misses        560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 1, 2024

Before [d2048f7] After [d32d775] Ratio Benchmark (Parameter)
3.90±1s 1.99±0.6s ~0.51 benchmarks.time_computation
3.35k 1.13k 0.34 benchmarks.mem_list

Click here to view all benchmarks.

@@ -1,3 +1,4 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sad because I think I know why this line has been added, and I think it is a bug in my recently-merged PPT change.

@drewoldag drewoldag merged commit 8ca2e8f into main Oct 1, 2024
7 of 8 checks passed
@drewoldag drewoldag deleted the awo/update-copier branch October 1, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants