-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to latest PPT version #79
Conversation
include_benchmarks: true | ||
include_docs: true | ||
include_notebooks: true | ||
mypy_type_checking: none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a lot of type annotations. Do we want to turn type checking on as a way to keep that habit?
(I ask not knowing if this does what I think it does or not 😄 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it could be a beneficial thing to do so. It will slow down committing code, but the value add might be appreciated by the end users. I'll create an issue for it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 35.55% 35.55%
=======================================
Files 18 18
Lines 869 869
=======================================
Hits 309 309
Misses 560 560 ☔ View full report in Codecov by Sentry. |
@@ -1,3 +1,4 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sad because I think I know why this line has been added, and I think it is a bug in my recently-merged PPT change.
No description provided.