Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from_flat 'index' keyword to 'on' #69

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Switch from_flat 'index' keyword to 'on' #69

merged 5 commits into from
Nov 6, 2024

Conversation

wilsonbb
Copy link
Collaborator

@wilsonbb wilsonbb commented Nov 6, 2024

Switches the from_flat arguments to reflect the new API introduced in nested-pandas 3.0. We pin however to 3.1 to take advantage of the fix introduced in lincc-frameworks/nested-pandas#173

We also have a testing hot fix for a serialization error with a note to more fully address in #71

Copy link

github-actions bot commented Nov 6, 2024

Before [973feca] After [49b29b3] Ratio Benchmark (Parameter)
509±5ms 596±9ms 1.17 benchmarks.NestedFrameQuery.time_run
250±3ms 257±2ms 1.02 benchmarks.NestedFrameReduce.time_run
141M 139M 0.98 benchmarks.NestedFrameAddNested.peakmem_run
248±5ms 243±2ms 0.98 benchmarks.NestedFrameAddNested.time_run
143M 141M 0.98 benchmarks.NestedFrameQuery.peakmem_run
140M 137M 0.98 benchmarks.NestedFrameReduce.peakmem_run

Click here to view all benchmarks.

@wilsonbb wilsonbb marked this pull request as ready for review November 6, 2024 22:48
@wilsonbb wilsonbb requested a review from hombit November 6, 2024 22:48
@wilsonbb wilsonbb merged commit f5019f7 into main Nov 6, 2024
7 checks passed
@wilsonbb wilsonbb deleted the unique_idx_fix branch November 6, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants