Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy v2 lints #110

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Numpy v2 lints #110

merged 2 commits into from
Jun 17, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Jun 17, 2024

Add ruff lint for numpy v2.0 compatibility and fix the only issue we had: np.NaN is replaced with np.nan in tests

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@hombit hombit requested a review from OliviaLynn June 17, 2024 12:45
Copy link

Before [c44bfe1] After [762019b] Ratio Benchmark (Parameter)
1.09±0.01ms 1.09±0.01ms 1.01 benchmarks.NestedFrameReduce.time_run
84.3M 84.6M 1 benchmarks.NestedFrameAddNested.peakmem_run
88.5M 88.4M 1 benchmarks.NestedFrameQuery.peakmem_run
6.14±0.05ms 6.12±0.1ms 1 benchmarks.NestedFrameQuery.time_run
87.6M 87.4M 1 benchmarks.NestedFrameReduce.peakmem_run
59.8±3ms 59.9±3ms 1 benchmarks.ReassignHalfOfNestedSeries.time_run
262M 256M 0.98 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
9.04±0.1ms 8.90±0.1ms 0.98 benchmarks.NestedFrameAddNested.time_run
34.6±2ms 32.8±2ms 0.95 benchmarks.AssignSingleDfToNestedSeries.time_run
283M 270M 0.95 benchmarks.ReassignHalfOfNestedSeries.peakmem_run

Click here to view all benchmarks.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (c44bfe1) to head (7035c0a).
Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          14       14           
  Lines         888      888           
=======================================
  Hits          883      883           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hombit hombit requested review from delucchi-cmu and removed request for OliviaLynn June 17, 2024 19:11
Copy link

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is silly =D

@hombit hombit merged commit 307c904 into main Jun 17, 2024
11 checks passed
@hombit hombit deleted the numpy-v2-lints branch June 17, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants