Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count Nested: Fixed Column Ordering #121

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Count Nested: Fixed Column Ordering #121

merged 2 commits into from
Jul 9, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Jul 9, 2024

Change Description

Resolves #109.

  • My PR includes a link to the issue that I am addressing

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.43%. Comparing base (307c904) to head (90e6915).
Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files          14       14           
  Lines         888      889    +1     
=======================================
+ Hits          883      884    +1     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 9, 2024

Before [307c904] After [25bb668] Ratio Benchmark (Parameter)
31.9±1ms 35.6±2ms ~1.12 benchmarks.AssignSingleDfToNestedSeries.time_run
6.32±0.1ms 6.54±0.09ms 1.03 benchmarks.NestedFrameQuery.time_run
60.3±2ms 62.2±3ms 1.03 benchmarks.ReassignHalfOfNestedSeries.time_run
9.09±0.1ms 9.24±0.9ms 1.02 benchmarks.NestedFrameAddNested.time_run
1.11±0.02ms 1.12±0.01ms 1.01 benchmarks.NestedFrameReduce.time_run
269M 272M 1.01 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
257M 258M 1.00 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
84.4M 84.3M 1.00 benchmarks.NestedFrameAddNested.peakmem_run
87.6M 87.4M 1.00 benchmarks.NestedFrameReduce.peakmem_run
90.7M 88.6M 0.98 benchmarks.NestedFrameQuery.peakmem_run

Click here to view all benchmarks.

@dougbrn dougbrn changed the title fixed column ordering Count Nested: Fixed Column Ordering Jul 9, 2024
@dougbrn dougbrn marked this pull request as ready for review July 9, 2024 18:17
@dougbrn dougbrn requested a review from hombit July 9, 2024 18:18
Copy link
Collaborator

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure it doesn't depend on the value ordering, could you please also make "b" to be a first element in the line 18?

@dougbrn dougbrn merged commit 3cd3baa into main Jul 9, 2024
11 checks passed
@dougbrn dougbrn deleted the fixed_column_ordering branch July 9, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Count Nested: Sort output columns of by behavior alphabetically for nested-dask meta
2 participants