Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count_nested: Update series name directly #127

Merged
merged 3 commits into from
Jul 26, 2024
Merged

count_nested: Update series name directly #127

merged 3 commits into from
Jul 26, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Jul 26, 2024

Change Description

Resolves #126. A small fix that is needed for the fornax demo.

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

github-actions bot commented Jul 26, 2024

Before [bcaf1b8] After [daf1df2] Ratio Benchmark (Parameter)
1.09±0ms 1.12±0.02ms 1.03 benchmarks.NestedFrameReduce.time_run
6.15±0.06ms 6.29±0.04ms 1.02 benchmarks.NestedFrameQuery.time_run
264M 263M 1 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
86.9M 86.9M 1 benchmarks.NestedFrameAddNested.peakmem_run
8.90±0.07ms 8.92±0.1ms 1 benchmarks.NestedFrameAddNested.time_run
91.3M 91.3M 1 benchmarks.NestedFrameQuery.peakmem_run
90.1M 90.1M 1 benchmarks.NestedFrameReduce.peakmem_run
286M 287M 1 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
31.8±2ms 31.4±2ms 0.99 benchmarks.AssignSingleDfToNestedSeries.time_run
60.6±3ms 57.1±3ms 0.94 benchmarks.ReassignHalfOfNestedSeries.time_run

Click here to view all benchmarks.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.44%. Comparing base (3cd3baa) to head (b8bcf1c).
Report is 59 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   99.43%   99.44%           
=======================================
  Files          14       14           
  Lines         889      899   +10     
=======================================
+ Hits          884      894   +10     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dougbrn dougbrn marked this pull request as ready for review July 26, 2024 21:30
@dougbrn dougbrn requested a review from wilsonbb July 26, 2024 21:30
@dougbrn dougbrn merged commit 71ae3ba into main Jul 26, 2024
11 checks passed
@dougbrn dougbrn deleted the fix-rename-bug branch July 26, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Count_nested: Instability in rename at Dask level
2 participants