Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .nest["field"] for chunked arrays #143

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Sep 6, 2024

This fixes #142: .nest["field_name"] didn't work for chunked arrays. It also fixes the similar functionality for accessing list-arrays

I ask for a new patch release after this is merged

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@hombit hombit requested a review from dougbrn September 6, 2024 18:01
Copy link

github-actions bot commented Sep 6, 2024

Before [0d8c2f3] <v0.2.1> After [3fd4c68] Ratio Benchmark (Parameter)
1.07±0.01ms 1.11±0.01ms 1.04 benchmarks.NestedFrameReduce.time_run
56.9±3ms 58.1±4ms 1.02 benchmarks.ReassignHalfOfNestedSeries.time_run
257M 258M 1 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
86.9M 87.2M 1 benchmarks.NestedFrameAddNested.peakmem_run
9.50±0.1ms 9.50±0.06ms 1 benchmarks.NestedFrameAddNested.time_run
91.9M 92.1M 1 benchmarks.NestedFrameQuery.peakmem_run
90.5M 90.8M 1 benchmarks.NestedFrameReduce.peakmem_run
6.60±0.3ms 6.55±0.09ms 0.99 benchmarks.NestedFrameQuery.time_run
32.9±2ms 32.0±2ms 0.97 benchmarks.AssignSingleDfToNestedSeries.time_run
284M 274M 0.97 benchmarks.ReassignHalfOfNestedSeries.peakmem_run

Click here to view all benchmarks.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (0d8c2f3) to head (8fca944).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          14       14           
  Lines         933      941    +8     
=======================================
+ Hits          928      936    +8     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Feel free to release a new version after you merge this, or let me know if you want me to do it.

@hombit hombit merged commit 6101d39 into main Sep 6, 2024
11 checks passed
@hombit hombit deleted the fix-nest-getter-chunked branch September 6, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using nest accessor raises AttributeError with chunked array
2 participants