Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate nest-resolver caches during assignment. #162

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

gitosaurus
Copy link
Contributor

Closes #159 .

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (a96a508) to head (0a2765e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          14       14           
  Lines         981      984    +3     
=======================================
+ Hits          976      979    +3     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [a96a508] After [0abd07e] Ratio Benchmark (Parameter)
29.8±5ms 43.8±5ms ~1.47 benchmarks.ReassignHalfOfNestedSeries.time_run
22.0±0.2ms 23.3±0.1ms 1.06 benchmarks.AssignSingleDfToNestedSeries.time_run
7.68±0.06ms 7.91±0.09ms 1.03 benchmarks.NestedFrameQuery.time_run
9.19±0.1ms 9.25±0.1ms 1.01 benchmarks.NestedFrameAddNested.time_run
1.60±0.01ms 1.62±0.01ms 1.01 benchmarks.NestedFrameReduce.time_run
266M 266M 1.00 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
88.2M 88.3M 1.00 benchmarks.NestedFrameAddNested.peakmem_run
93.1M 93.2M 1.00 benchmarks.NestedFrameQuery.peakmem_run
91.9M 91.9M 1.00 benchmarks.NestedFrameReduce.peakmem_run
285M 285M 1.00 benchmarks.ReassignHalfOfNestedSeries.peakmem_run

Click here to view all benchmarks.

@gitosaurus gitosaurus enabled auto-merge (rebase) October 29, 2024 21:59
Copy link
Contributor

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gitosaurus gitosaurus merged commit b8707a9 into main Oct 29, 2024
10 checks passed
@gitosaurus gitosaurus deleted the fix-nested-cache-GH159 branch October 29, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NestedFrame.eval does not recognize new columns in existing nests in multiline strings
2 participants