Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up NestedExtensionArray.copy #164

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Speed up NestedExtensionArray.copy #164

merged 1 commit into from
Oct 31, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Oct 30, 2024

We don't need to validate data when we make a shallow copy of the extension array. Also, this fixes a typo.

@hombit hombit requested a review from wilsonbb October 30, 2024 15:01
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (b8707a9) to head (a3ce966).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          14       14           
  Lines         984      984           
=======================================
  Hits          979      979           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Before [b8707a9] After [db13823] Ratio Benchmark (Parameter)
266M 266M 1 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
88.4M 88.1M 1 benchmarks.NestedFrameAddNested.peakmem_run
93.3M 93.1M 1 benchmarks.NestedFrameQuery.peakmem_run
91.9M 91.6M 1 benchmarks.NestedFrameReduce.peakmem_run
285M 285M 1 benchmarks.ReassignHalfOfNestedSeries.peakmem_run
9.27±0.1ms 9.15±0.2ms 0.99 benchmarks.NestedFrameAddNested.time_run
7.93±0.1ms 7.84±0.07ms 0.99 benchmarks.NestedFrameQuery.time_run
1.59±0.02ms 1.58±0.03ms 0.99 benchmarks.NestedFrameReduce.time_run
31.7±5ms 30.5±6ms 0.96 benchmarks.ReassignHalfOfNestedSeries.time_run
23.4±0.8ms 22.2±0.05ms 0.95 benchmarks.AssignSingleDfToNestedSeries.time_run

Click here to view all benchmarks.

@hombit hombit merged commit d379665 into main Oct 31, 2024
10 checks passed
@hombit hombit deleted the ext-array-copy branch October 31, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants