-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial query wrapping #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 91.59% 92.75% +1.15%
==========================================
Files 11 12 +1
Lines 488 552 +64
==========================================
+ Hits 447 512 +65
+ Misses 41 40 -1 ☔ View full report in Codecov by Sentry. |
hombit
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Addresses MVP: Wrap Query Function - allow nested access #10.
Solution Description
This PR wraps the pandas query function. Before executing any query, it first checks the input query string for spacing between the various components. I needed this to essentially be able to split each component apart and check to see if it was targeting a nested column using the "nested_frame.nested_column" access pattern. It then builds a set of subqueries for each targeted layer. At the moment, I limited this to only having one layer be targetable at a time, but we could allow multiple queries to execute within the query call down the road.
One note, is that using the "." is slightly overloaded in Pandas eval syntax. You can use "column.property" within eval normally. We override this by splitting on it and removing the dot, so some subset of queries full functionality is probably limited. I think this implementation should be sufficient for the MVP however, and we can come back to make this more robust in a later stage of the project.
Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist
New Feature Checklist