-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap dropna #26
Wrap dropna #26
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 94.49% 94.92% +0.43%
==========================================
Files 13 13
Lines 563 611 +48
==========================================
+ Hits 532 580 +48
Misses 31 31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, it is great!
Co-authored-by: Konstantin Malanchev <[email protected]>
Co-authored-by: Konstantin Malanchev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some drive-by comments since I was reading the PR to understand the current nested-pandas state.
A more general comment: I would assume as a user I would be interested in trying something like
df.dropna(axis='columns', on_nested=True)
and that it would drop NaNs from all of the base columns as well as all of the columns in each of the nested frames. But it looks like this isn't currently possible with the requirement that that we only target on nested structure though I may be reading incorrectly. Not necessarily a blocker for a MVP, but wanted to comment on my surprise
Change Description
Resolves MVP: Wrapping dropna #11.
Solution Description
Wraps dropna and enables hierarchical column names to work within the
subset
kwarg. Additionally, adds theon_nested
kwarg to allow users to specify a nested layer to use dropna on, the motivation being that a user just wants to run on a layer and doesn't want to use a subset of columns within that layer.Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist
New Feature Checklist
Documentation Change Checklist
Build/CI Change Checklist
Other Change Checklist