Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks for nested element assignment #54

Merged
merged 2 commits into from
May 7, 2024
Merged

Benchmarks for nested element assignment #54

merged 2 commits into from
May 7, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented May 4, 2024

Adds two pairs of benchmarks: time and peak memory usage for single element assignment and massive (len(series)//2) assignment to a nested series.

This PR partially implements #37, and gives some information for #53.

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@hombit hombit requested a review from wilsonbb May 4, 2024 23:55
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (49b03ff) to head (7e3cd15).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files          14       14           
  Lines         801      801           
=======================================
  Hits          781      781           
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 4, 2024

Before [49b03ff] After [e2875db] Ratio Benchmark (Parameter)
31.9±3ms 39.4±7ms ~1.23 benchmarks.AssignSingleDfToNestedSeries.time_run
53.4±2ms 56.8±2ms 1.06 benchmarks.ReassignHalfOfNestedSeries.time_run
258M 257M 1.00 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
275M 271M 0.98 benchmarks.ReassignHalfOfNestedSeries.peakmem_run

Click here to view all benchmarks.

Copy link
Contributor

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@hombit hombit merged commit ab5fc4c into main May 7, 2024
11 checks passed
@hombit hombit deleted the bench-assign branch May 7, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants