Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

Rename delete_field -> pop_field #35

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Rename delete_field -> pop_field #35

merged 1 commit into from
Feb 11, 2024

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Feb 11, 2024

Fix #28

Change Description

  • My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@hombit hombit merged commit 24d32a0 into main Feb 11, 2024
1 check passed
@hombit hombit deleted the remore-pop-fields branch February 11, 2024 01:56
Copy link

Before [24d32a0] After [e942e0b] Ratio Benchmark (Parameter)
0 0 n/a benchmarks.mem_list
1.06±0ms 1.06±0ms 1.00 benchmarks.time_computation

Click here to view all benchmarks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename .delete_field to pop_field
1 participant