Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed AsyncServerInterceptor to be compatible with OpenTelmetry #5938

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed AsyncServerInterceptor to be compatible with OpenTelmetry #5938

wants to merge 1 commit into from

Conversation

ikhoon
Copy link
Contributor

@ikhoon ikhoon commented Oct 14, 2024

Motivation:

There was a bug in AsyncServerInterceptor where a ForwardingServerCall was not unwrapped properly via reflection. Because of that, OpenTelemetry's TracingServerCall that wraps the existing ServerCall using ForwardingServerCall was rejected by the following condition.

armeria/grpc/src/main/java/com/linecorp/armeria/server/grpc/DeferredListener.java

Lines 51 to 52 in 6dd5cd1

final AbstractServerCall<I, ?> armeriaServerCall = ServerCallUtil.findArmeriaServerCall(serverCall);
checkState(armeriaServerCall != null, "Cannot use %s with a non-Armeria gRPC server. ServerCall: %s",

Modifications:

  • Use the correct reflection API to unsafely access ForwardingServerCall.delegate().

Result:

@ikhoon
Fixed AsyncServerInterceptor to be compatible with OpenTelmetry
65db0ac 
Motivation:

There was a bug in `AsyncServerInterceptor` where a `ForwardingServerCall`
was not unwrapped properly via reflection. Because of that,
OpenTelemetry's `TracingServerCall` that wraps the existing
`ServerCall` using `ForwardingServerCall` was rejected by the following
condition.
https://github.com/line/armeria/blob/6dd5cd18dcdc32431316f272128287b2037249d3/grpc/src/main/java/com/linecorp/armeria/server/grpc/DeferredListener.java#L51-L52

Modifications:

- Use the correct reflection API to unsafely access
  `ForwardingServerCall.delegate()`.

Result:

- Fix a bug where `AsyncServerInterceptor` is incompatible with
  the OpenTelemetry gRPC agent.
- Closes line#5937
@ikhoon ikhoon added the defect label Oct 14, 2024
@ikhoon ikhoon added this to the 1.31.0 milestone Oct 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔍 Build Scan® (commit: 65db0ac)

Job name Status Build Scan®
build-ubicloud-standard-8-jdk-8 ✅ https://ge.armeria.dev/s/mkmsxs2v4w5yq
build-ubicloud-standard-8-jdk-21-snapshot-blockhound ✅ https://ge.armeria.dev/s/qgvxhbmgyoi7q
build-ubicloud-standard-8-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/poygs23dspzc6
build-ubicloud-standard-8-jdk-17-min-java-11 ✅ https://ge.armeria.dev/s/flggfpwtobclg
build-ubicloud-standard-8-jdk-17-leak ✅ https://ge.armeria.dev/s/efzpnx5bcredy
build-ubicloud-standard-8-jdk-11 ✅ https://ge.armeria.dev/s/yl7r2dlttbnpy
build-macos-12-jdk-21 ✅ https://ge.armeria.dev/s/k2cjeqj7oj47w

jrhee17
jrhee17 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhee17 jrhee17 jrhee17 approved these changes

@minwoox minwoox Awaiting requested review from minwoox minwoox is a code owner

@trustin trustin Awaiting requested review from trustin trustin is a code owner

Assignees
No one assigned
Labels
defect
Projects
None yet
Milestone
1.31.0
Development

Successfully merging this pull request may close these issues.

gRPC AsyncServerInterceptor throws an exception when opentelemetry-javaagent is enabled
2 participants
@ikhoon @jrhee17