Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed AsyncServerInterceptor to be compatible with OpenTelmetry #5938

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed AsyncServerInterceptor to be compatible with OpenTelmetry #5938

wants to merge 1 commit into from

Commits on Oct 14, 2024

  1. Fixed AsyncServerInterceptor to be compatible with OpenTelmetry 

    Motivation:

There was a bug in `AsyncServerInterceptor` where a `ForwardingServerCall`
was not unwrapped properly via reflection. Because of that,
OpenTelemetry's `TracingServerCall` that wraps the existing
`ServerCall` using `ForwardingServerCall` was rejected by the following
condition.
https://github.com/line/armeria/blob/6dd5cd18dcdc32431316f272128287b2037249d3/grpc/src/main/java/com/linecorp/armeria/server/grpc/DeferredListener.java#L51-L52

Modifications:

- Use the correct reflection API to unsafely access
  `ForwardingServerCall.delegate()`.

Result:

- Fix a bug where `AsyncServerInterceptor` is incompatible with
  the OpenTelemetry gRPC agent.
- Closes line#5937
    @ikhoon
    ikhoon committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    65db0ac View commit details
    Browse the repository at this point in the history