Provide a way to terminate unfinished requests after graceful shutdown #5941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Unfinished requests even after graceful shutdown period are forcivily closed with
ClosedSessionException
. AsClosedSessionException
indicates that the connection was unexpectedly disconnected,ClosedSessionException
is not suitable for graceful shutdown.In this PR, I propose to add
ShuttingDownException
to terminate unfinished requests when a server stops.Modifications:
GracefulShutdown
to customize graceful shutdown behavior.HttpServerHandler
to send error responses using the error function ofGracefulShutdown
Server
to send error respones first and then close the connnections.ServerConfig.gracefulShutdownQuietPeriod()
andServerConfig.gracefulShutdownTimeout()
have been deprecated in favor ofServerConfig.gracefulShutdown()
.Result:
You can now use
GracefulShutdown
to terminate unfinished requests when a server stops.