[test_scenes] Port longpathdash test case from Skia #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armansito
force-pushed
the
pr-longpathdash
branch
from
dc5c366
to
2af65bc
Compare
This is a single very long path that results in a large number of line segments when dashing is applied. This demonstrates rendering artifacts.
armansito
force-pushed
the
pr-longpathdash
branch
from
2af65bc
to
87b2703
Compare
DJMcNab
reviewed
Oct 11, 2023
examples/scenes/src/test_scenes.rs
Outdated
| @@ -21,26 +21,21 @@ macro_rules! scene { | |||
| function: Box::new($name), | |||
There was a problem hiding this comment.
I'd probably express this case (lines 16-22) in terms of the new addition
Yes of course! This is the expected shape with butt caps: This is the same butt cap render showing artifacts when it's zoomed out: This is the same shape with round caps (which increases the line segment count) showing artifacts at a moderate zoom level: The latter can be fixed by increasing the bump buffer sizes. I'm treating this as a pathological case with a very high memory requirement. The zoomed out case appears regardless of the size of the bump buffers so that's probably a separate issue. |
Added a butt cap and round cap variant of the pathological longpathdash test case. The round caps exhibit the expected increase in the number of line segments post-flattening, and hence a significant increase in required GPU memory. Also added a new `scene!` macro variant for custom test names and factory functions that return a test function.
armansito
force-pushed
the
pr-longpathdash
branch
from
6c8ce4e
to
99f92eb
Compare
raphlinus
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a single very long path that results in a large number of line segments when dashing is applied. This demonstrates rendering artifacts.