Fix shader compilation on Chrome #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphlinus
approved these changes
Oct 16, 2023
| @@ -5,7 +5,7 @@ | |||
| #import bump | |||
|
|
|||
| @group(0) @binding(0) | |||
| var<storage> bump: BumpAllocators; | |||
| var<storage, read_write> bump: BumpAllocators; | |||
There was a problem hiding this comment.
I can see this is a reasonable patch. It feels odd to me that an atomic load requires a read-write binding, but I checked the spec and it is. I was thrown off a bit by the fact that it isn't considered a write access (see 13.5.1).
Another possible approach would be to have a non-atomic version of the struct. This is done for AtomicPathBbox (which is going away when monoid bbox computation lands) and AtomicTile. However, in this case I think it's better to have one source of truth, as the bump struct will almost certainly continue to evolve.
shader/path_tiling.wgsl
Outdated
| let sign = select(-1.0, 1.0, is_positive_slope); | ||
| let xt0 = floor(s0.x * sign); | ||
| let c = s0.x * sign - xt0; | ||
| let sign_ = select(-1.0, 1.0, is_positive_slope); |
There was a problem hiding this comment.
Makes sense but I'm not in love. I think I might prefer xsign (or possibly x_sign as it represents the sign of dx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has some fixes for shader compilation on Chrome.
The
signvariable shadows thesignfunction, so it's renamed.Atomics must have a
read_writebinding soBumpAllocatorsusage is changed.