Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting AA method dynamically #400

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Support setting AA method dynamically #400

merged 5 commits into from
Nov 1, 2023

Commits on Nov 1, 2023

  1. Support setting AA method dynamically 

    This replaces the static anti-aliasing setting with a dynamic option in
the form of two new settings (one used during pipeline creation and one
used during a render):

- The `FullShaders` collection now maintains up to 3 `fine` stage
  pipeline variants. This can be driven using a new optional
  `RendererOptions` field called `preferred_antialiasing_method`, which
  determines which fine stage pipeline variants should get  instantiated
  at start up.

- `RenderParams` now requires an `AaConfig` which selects which `fine`
  stage variant to use.

- Added a new key binding (`M`) to the `with_winit` example to
  dynamically cycle through all 3 AA methods.
    @armansito
    armansito committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    42f1246 View commit details
    Browse the repository at this point in the history

  2. MSAA config: address review comments

    @armansito
    armansito committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    fba8317 View commit details
    Browse the repository at this point in the history

  3. Change preferred_antialiasing_method setting to a struct 

    Instead of passing in a single optional mode to enable, the caller can
now specify which set of AA methods to compile.
    @armansito
    armansito committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    ea29d30 View commit details
    Browse the repository at this point in the history

  4. MSAA config: address last round of comments

    @armansito
    armansito committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    1efb3a5 View commit details
    Browse the repository at this point in the history

  5. Fix unused warning with the headless example

    @armansito
    armansito committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    876a934 View commit details
    Browse the repository at this point in the history