Skip to content

Commit

Permalink
Return WARN if blob_last_used_by returns an Err in validators (#2698)
Browse files Browse the repository at this point in the history
## Motivation

Currently if a call to `blob_last_used_by` returns an `Err`, we'll print a `ERROR` level log. That is not very accurate because validators could still be not fully in sync and some of them could be missing some blobs.

## Proposal

Change log level to `WARN`

## Test Plan

CI

## Release Plan

- Nothing to do / These changes follow the usual release cycle.
  • Loading branch information
Andre da Silva authored Oct 23, 2024
1 parent 10d9e46 commit 98084e5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions linera-service/src/proxy/grpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ use tonic::{
Request, Response, Status,
};
use tower::{builder::ServiceBuilder, Layer, Service};
use tracing::{debug, info, instrument, Instrument as _};
use tracing::{debug, info, instrument, Instrument as _, Level};
#[cfg(with_metrics)]
use {
linera_base::prometheus_util,
Expand Down Expand Up @@ -512,7 +512,7 @@ where
)?))
}

#[instrument(skip_all, err(Display))]
#[instrument(skip_all, err(level = Level::WARN))]
async fn blob_last_used_by(
&self,
request: Request<BlobId>,
Expand Down

0 comments on commit 98084e5

Please sign in to comment.