Add some process_inbox calls for the matching_engine end to end test
#2129
Conversation
| node_service_admin.process_inbox(&chain_admin).await?; | ||
| node_service_a.process_inbox(&chain_a).await?; | ||
| node_service_b.process_inbox(&chain_b).await?; |
There was a problem hiding this comment.
Yes these ones look necessary.
| @@ -1500,6 +1503,9 @@ async fn test_wasm_end_to_end_matching_engine(config: impl LineraNetConfig) -> R | |||
| &[token0.forget_abi(), token1.forget_abi()], | |||
| ) | |||
| .await?; | |||
| node_service_admin.process_inbox(&chain_admin).await?; | |||
| node_service_a.process_inbox(&chain_a).await?; | |||
| node_service_b.process_inbox(&chain_b).await?; | |||
There was a problem hiding this comment.
These ones look too early. We want to make sure that the RequestApplication messages are processed, then their answers.
There was a problem hiding this comment.
Ok, I changed the position of the process_inbox statements.
| node_service_admin.process_inbox(&chain_admin).await?; | ||
| node_service_a.process_inbox(&chain_a).await?; | ||
| node_service_b.process_inbox(&chain_b).await?; |
There was a problem hiding this comment.
What messages are these waiting for?
I don't think admin and b are needed, and a should maybe move to after line 1513?
There was a problem hiding this comment.
@MathieuDutSik I believe the process_inbox are useful when they happen between request_application and make_application
There was a problem hiding this comment.
Ok, I changed the position of the process_inbox for a and b and eliminated it for admin.
|
This attempt was in the right direction but was superseded by PR #2144 |
Motivation
Replacement of the error
failed to post querywith a more precise error message revealed the origin of some errors.Proposal
Two entries of
process_queriesare added to thematching_engine.It is possible that the iterative loop for
make_applicationneeds to be eliminated.Test Plan
An improved CI is the objective of this work.
Release Plan
Not relevant.
Links