Create ChainWorkerActor
#2135
Merged
Create ChainWorkerActor
#2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A wrapper for a `ChainWorkerState` that runs on its own separate task.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Collect common code into the helper method.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
Handle the request in the `ChainWorkerActor`.
Prepare to have the actor run for a longer term.
The `ChainWorkerActor` is used instead.
ma2bd
approved these changes
Jun 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the
ChainStateViewis reloaded for every worker operation. This is inefficient because it involves deserializing data every time.Proposal
Create a
ChainWorkerActorthat wraps aChainWorkerStateand keeps it loaded while the actor is running. For now, even though actors run on new tasks, they only handle one operation and then finish the task. A separate PR will make them long-lived.Test Plan
This is an internal refactor, so existing tests should catch any regressions.
Release Plan
This is an internal refactor, so nothing is needed.
Links