Test clippy lint for large futures

clippy.toml

@@ -0,0 +1 @@
+future-size-threshold = 5000

examples/counter/src/contract.rs

@@ -61,7 +61,7 @@ impl Contract for CounterContract {
 
 #[cfg(test)]
 mod tests {
-    use futures::FutureExt;
+    use futures::FutureExt as _;
     use linera_sdk::{
         util::BlockingWait,
         views::{View, ViewStorageContext},

examples/counter/src/service.rs

@@ -70,7 +70,7 @@ impl QueryRoot {
 #[cfg(test)]
 mod tests {
     use async_graphql::{Request, Response, Value};
-    use futures::FutureExt;
+    use futures::FutureExt as _;
     use linera_sdk::{
         util::BlockingWait,
         views::{View, ViewStorageContext},

linera-base/src/lib.rs

@@ -1,12 +1,13 @@
 // Copyright (c) Zefchain Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
-#![deny(missing_docs)]
-
 //! This module provides a common set of types and library functions that are shared
 //! between the Linera protocol (compiled from Rust to native code) and Linera
 //! applications (compiled from Rust to Wasm).
 
+#![deny(missing_docs)]
+#![deny(clippy::large_futures)]
+
 #[doc(hidden)]
 pub use async_trait::async_trait;
 

linera-chain/src/lib.rs

@@ -3,6 +3,8 @@
 
 //! This module manages the state of a Linera chain, including cross-chain communication.
 
+#![deny(clippy::large_futures)]
+
 mod chain;
 pub mod data_types;
 mod inbox;

linera-chain/src/unit_tests/chain_tests.rs

@@ -1,6 +1,8 @@
 // Copyright (c) Zefchain Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
+#![allow(clippy::large_futures)]
+
 use std::{iter, sync::Arc};
 
 use assert_matches::assert_matches;

linera-core/src/chain_worker/state.rs

@@ -9,7 +9,7 @@ use std::{
     sync::Arc,
 };
 
-use futures::{future, FutureExt};
+use futures::{future, FutureExt as _};
 use linera_base::{
     crypto::CryptoHash,
     data_types::{ArithmeticError, BlockHeight, HashedBlob},
@@ -189,9 +189,7 @@ where
         let local_time = self.storage.clock().current_time();
         let signer = block.authenticated_signer;
 
-        let executed_block = self
-            .chain
-            .execute_block(&block, local_time, None)
+        let executed_block = Box::pin(self.chain.execute_block(&block, local_time, None))
             .await?
             .with(block);
 
@@ -344,10 +342,11 @@ where
         );
         self.storage.clock().sleep_until(block.timestamp).await;
         let local_time = self.storage.clock().current_time();
-        let outcome = self
-            .chain
-            .execute_block(block, local_time, oracle_records.clone())
-            .await?;
+        let outcome = Box::pin(
+            self.chain
+                .execute_block(block, local_time, oracle_records.clone()),
+        )
+        .await?;
         if let Some(lite_certificate) = &validated_block_certificate {
             let value = HashedCertificateValue::new_validated(outcome.clone().with(block.clone()));
             lite_certificate
@@ -534,10 +533,12 @@ where
         // Execute the block and update inboxes.
         self.chain.remove_events_from_inboxes(block).await?;
         let local_time = self.storage.clock().current_time();
-        let verified_outcome = self
-            .chain
-            .execute_block(block, local_time, Some(oracle_records.clone()))
-            .await?;
+        let verified_outcome = Box::pin(self.chain.execute_block(
+            block,
+            local_time,
+            Some(oracle_records.clone()),
+        ))
+        .await?;
         // We should always agree on the messages and state hash.
         ensure!(
             *messages == verified_outcome.messages,

linera-core/src/join_set_ext.rs

@@ -14,7 +14,7 @@ use std::{
     task::{Context, Poll},
 };
 
-use futures::FutureExt;
+use futures::FutureExt as _;
 use tokio::{
     sync::oneshot,
     task::{AbortHandle, JoinSet},

linera-core/src/lib.rs

@@ -4,6 +4,8 @@
 
 //! This module defines the core Linera protocol.
 
+#![deny(clippy::large_futures)]
+
 pub mod chain_worker;
 pub mod client;
 pub mod data_types;

linera-core/src/unit_tests/wasm_client_tests.rs

@@ -10,6 +10,7 @@
 // because they are slow and their behavior appears to be correctly check by the
 // test with memory.
 
+#![allow(clippy::large_futures)]
 #![cfg(any(feature = "wasmer", feature = "wasmtime"))]
 
 use std::collections::BTreeMap;

linera-core/src/unit_tests/wasm_worker_tests.rs

@@ -7,6 +7,7 @@
 //! These tests only run if a Wasm runtime has been configured by enabling either the `wasmer` or
 //! the `wasmtime` feature flags.
 
+#![allow(clippy::large_futures)]
 #![cfg(any(feature = "wasmer", feature = "wasmtime"))]
 
 use std::sync::Arc;

linera-core/src/unit_tests/worker_tests.rs

@@ -2,6 +2,8 @@
 // Copyright (c) Zefchain Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
+#![allow(clippy::large_futures)]
+
 #[path = "./wasm_worker_tests.rs"]
 mod wasm;
 

linera-execution/src/lib.rs

@@ -3,6 +3,8 @@
 
 //! This module manages the execution of the system application and the user applications in a Linera chain.
 
+#![deny(clippy::large_futures)]
+
 mod applications;
 pub mod committee;
 mod execution;

linera-rpc/src/grpc/server.rs

@@ -11,7 +11,7 @@ use std::{
 use futures::{
     channel::{mpsc, mpsc::Receiver},
     future::BoxFuture,
-    FutureExt, StreamExt,
+    FutureExt as _, StreamExt,
 };
 use linera_base::identifiers::ChainId;
 use linera_core::{

linera-rpc/src/lib.rs

@@ -4,6 +4,7 @@
 //! This module provides network abstractions and the data schemas for remote procedure
 //! calls (RPCs) in the Linera protocol.
 
+#![deny(clippy::large_futures)]
 // `tracing::instrument` is not compatible with this nightly Clippy lint
 #![allow(unknown_lints)]
 #![allow(clippy::blocks_in_conditions)]

linera-sdk/src/test/validator.rs

@@ -12,7 +12,7 @@ use std::sync::{
 };
 
 use dashmap::DashMap;
-use futures::FutureExt;
+use futures::FutureExt as _;
 use linera_base::{
     crypto::KeyPair,
     data_types::Timestamp,

linera-sdk/src/util.rs

@@ -77,7 +77,7 @@ where
 mod tests {
     use std::task::{Context, Poll};
 
-    use futures::{future::poll_fn, task::noop_waker, FutureExt};
+    use futures::{future::poll_fn, task::noop_waker, FutureExt as _};
 
     use super::{yield_once, BlockingWait};
 

linera-sdk/src/views/mock_key_value_store.rs

@@ -11,7 +11,7 @@ use std::{
     },
 };
 
-use futures::FutureExt;
+use futures::FutureExt as _;
 use linera_views::{
     batch::Batch,
     common::{ReadableKeyValueStore, WritableKeyValueStore},

linera-service/src/grpc_proxy.rs

@@ -15,7 +15,7 @@ use std::{
 
 use anyhow::Result;
 use async_trait::async_trait;
-use futures::{future::BoxFuture, FutureExt};
+use futures::{future::BoxFuture, FutureExt as _};
 use linera_base::identifiers::ChainId;
 use linera_core::{notifier::Notifier, JoinSetExt as _};
 use linera_rpc::{

linera-service/src/lib.rs

@@ -4,6 +4,8 @@
 
 //! This module provides the executables needed to operate a Linera service, including a placeholder wallet acting as a GraphQL service for user interfaces.
 
+#![deny(clippy::large_futures)]
+
 pub mod chain_listener;
 pub mod cli_wrappers;
 pub mod config;

linera-service/src/linera/client_options.rs

@@ -4,6 +4,7 @@
 use std::{env, iter, num::NonZeroU16, path::PathBuf, time::Duration};
 
 use chrono::{DateTime, Utc};
+use futures::FutureExt as _;
 use linera_base::{
     crypto::PublicKey,
     data_types::{Amount, ApplicationPermissions, TimeDelta},
@@ -139,6 +140,7 @@ impl ClientOptions {
             self.wasm_runtime.with_wasm_default(),
             Job(self, wallet),
         )
+        .boxed()
         .await?;
         Ok(())
     }

linera-service/src/linera/main.rs

@@ -2,6 +2,8 @@
 // Copyright (c) Zefchain Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
+#![deny(clippy::large_futures)]
+
 use std::{collections::HashMap, env, path::PathBuf, sync::Arc, time::Instant};
 
 use anyhow::{anyhow, bail, ensure, Context};
@@ -10,7 +12,7 @@ use chrono::Utc;
 use client_context::ClientContext;
 use client_options::ClientOptions;
 use colored::Colorize;
-use futures::{lock::Mutex, StreamExt};
+use futures::{lock::Mutex, FutureExt as _, StreamExt};
 use linera_base::{
     crypto::{CryptoHash, CryptoRng, PublicKey},
     data_types::{ApplicationPermissions, Timestamp},
@@ -1323,7 +1325,7 @@ async fn run(options: ClientOptions) -> anyhow::Result<()> {
             let mut wallet_state = options.create_wallet(genesis_config, *testing_prng_seed)?;
             wallet_state.extend(chains);
             wallet_state.save()?;
-            options.initialize_storage().await?;
+            options.initialize_storage().boxed().await?;
             Ok(())
         }
 
@@ -1479,7 +1481,7 @@ Make sure to use a Linera client compatible with this network.
                         .map(|chain_id| UserChain::make_other(*chain_id, timestamp)),
                 );
                 wallet.save()?;
-                options.initialize_storage().await?;
+                options.initialize_storage().boxed().await?;
                 if *with_new_chain {
                     ensure!(
                         faucet.is_some(),

linera-service/src/proxy.rs

@@ -1,11 +1,13 @@
 // Copyright (c) Zefchain Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
+#![deny(clippy::large_futures)]
+
 use std::{net::SocketAddr, path::PathBuf, time::Duration};
 
 use anyhow::{bail, Result};
 use async_trait::async_trait;
-use futures::{SinkExt, StreamExt};
+use futures::{FutureExt as _, SinkExt, StreamExt};
 use linera_core::{node::NodeError, JoinSetExt as _};
 use linera_rpc::{
     config::{
@@ -341,6 +343,7 @@ impl ProxyOptions {
             None,
             ProxyContext::from_options(self)?,
         )
+        .boxed()
         .await
     }
 }

linera-service/src/server.rs

@@ -2,11 +2,13 @@
 // Copyright (c) Zefchain Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
+#![deny(clippy::large_futures)]
+
 use std::{path::PathBuf, time::Duration};
 
 use anyhow::bail;
 use async_trait::async_trait;
-use futures::{stream::FuturesUnordered, FutureExt, StreamExt, TryFutureExt};
+use futures::{stream::FuturesUnordered, FutureExt as _, StreamExt, TryFutureExt as _};
 use linera_base::crypto::{CryptoRng, KeyPair};
 use linera_core::{worker::WorkerState, JoinSetExt as _};
 use linera_execution::{committee::ValidatorName, WasmRuntime, WithWasmDefault};
@@ -466,6 +468,7 @@ async fn run(options: ServerOptions) {
                 .await
                 .unwrap();
             run_with_storage(full_storage_config, &genesis_config, wasm_runtime, job)
+                .boxed()
                 .await
                 .unwrap();
         }

linera-service/src/unit_tests/chain_listener.rs

@@ -1,10 +1,12 @@
 // Copyright (c) Zefchain Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
+#![allow(clippy::large_futures)]
+
 use std::{collections::BTreeMap, sync::Arc};
 
 use async_trait::async_trait;
-use futures::lock::Mutex;
+use futures::{lock::Mutex, FutureExt as _};
 use linera_base::{
     crypto::{KeyPair, PublicKey},
     data_types::{Amount, BlockHeight, TimeDelta, Timestamp},
@@ -177,7 +179,7 @@ async fn test_chain_listener() -> anyhow::Result<()> {
         .transfer(None, Amount::ONE, recipient0, UserData::default())
         .await?;
     for i in 0.. {
-        client0.synchronize_from_validators().await?;
+        client0.synchronize_from_validators().boxed().await?;
         let balance = client0.local_balance().await?;
         if balance == Amount::from_tokens(2) {
             break;

linera-service/src/unit_tests/faucet.rs

@@ -1,6 +1,8 @@
 // Copyright (c) Zefchain Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
+#![allow(clippy::large_futures)]
+
 use std::sync::Arc;
 
 use async_trait::async_trait;

linera-storage-service/src/lib.rs

@@ -4,6 +4,8 @@
 //! This module provides a shared key-value store server based on the RocksDB store and the in-memory store of `linera-views`.
 //! The corresponding client implements the `KeyValueStore` and `AdminKeyValueStore` traits.
 
+#![deny(clippy::large_futures)]
+
 #[allow(clippy::derive_partial_eq_without_eq)]
 // https://github.com/hyperium/tonic/issues/1056
 pub mod key_value_store {

linera-storage/src/lib.rs

@@ -3,6 +3,8 @@
 
 //! This module defines the storage abstractions for individual chains and certificates.
 
+#![deny(clippy::large_futures)]
+
 mod chain_guards;
 mod db_storage;
 #[cfg(with_dynamodb)]

linera-storage/src/unit_tests/chain_guards.rs

@@ -10,7 +10,7 @@ use std::{
     time::Duration,
 };
 
-use futures::FutureExt;
+use futures::FutureExt as _;
 use linera_base::identifiers::ChainId;
 use tokio::{sync::Barrier, time::sleep};