Correct the paths for the computation of the RPC API hash and WIT API hash
#2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
reviewed
Jun 17, 2024
| @@ -192,7 +192,7 @@ impl VersionInfo { | |||
| .into(); | |||
|
|
|||
| let rpc_hash = | |||
| get_hash(paths, &metadata, "linera-rpc", "tests/staged/formats.yaml")?.into(); | |||
| get_hash(paths, &metadata, "linera-rpc", "proto/rpc.proto")?.into(); | |||
There was a problem hiding this comment.
The previous file is more like tests/snapshots/format__format.yaml.snap.
|
Thanks for looking into this! |
jvff
approved these changes
Jun 18, 2024
ma2bd
reviewed
Jun 18, 2024
| @@ -103,14 +103,17 @@ fn get_hash( | |||
|
|
|||
| let package_glob = format!("{}/{}", package_root.display(), glob); | |||
|
|
|||
| let mut n_file = 0; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
RPC API hashandWIT API hashwere showing the same value which is not what one expects.Proposal
The explanation was that the paths were incorrect. Once corrected, we obtained reasonable values.
Test Plan
We check that the hashes are different.
Release Plan
Not relevant.
Links