Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track the certified block that published a blob last #2156

Merged

Conversation

ndr-ds
Copy link
Contributor

@ndr-ds ndr-ds commented Jun 18, 2024

Motivation

For example, if we know a certain blob was published, and we try to use it, but some of the validators don't have it, we need to be able to know the certificate that last used the blob so that we can sync validators to also have that blob. That's one use case for this, but there are more. Part of #2033

Proposal

Track what Certificate last used the blob. As of right now, the only "usage" is publishing a blob, but in the future we'll also use it in the read_blob system API call, when we replace Bytecode with blobs, etc.

Test Plan

CI + will use this in following PRs

Copy link
Contributor Author

ndr-ds commented Jun 18, 2024

Copy link

graphite-app bot commented Jun 18, 2024

Graphite Automations

"Assign reviewers" took an action on this PR • (06/18/24)

6 reviewers were added to this PR based on Andre da Silva's automation.

@ndr-ds ndr-ds force-pushed the 06-18-track_the_certified_block_that_published_a_blob_last branch from 4d03523 to 38daae1 Compare June 20, 2024 10:16
@ndr-ds ndr-ds force-pushed the 06-18-track_the_certified_block_that_published_a_blob_last branch from 38daae1 to 6825d07 Compare June 20, 2024 10:17
Copy link
Contributor Author

ndr-ds commented Jun 20, 2024

Merge activity

  • Jun 20, 8:16 AM EDT: @andresilva91 started a stack merge that includes this pull request via Graphite.
  • Jun 20, 8:17 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 20, 8:18 AM EDT: @andresilva91 merged this pull request with Graphite.

@ndr-ds ndr-ds force-pushed the 06-18-track_the_certified_block_that_published_a_blob_last branch from 6825d07 to a977ea2 Compare June 20, 2024 12:16
@ndr-ds ndr-ds merged commit 7b31acd into main Jun 20, 2024
5 checks passed
@ndr-ds ndr-ds deleted the 06-18-track_the_certified_block_that_published_a_blob_last branch June 20, 2024 12:18
ndr-ds pushed a commit that referenced this pull request Jun 20, 2024
…n validator (#2158)

## Motivation

Building on top of #2156, there we will need this endpoint for the client to communicate with the validators. Fixes #2030

## Proposal

Adds an endpoint to get what `Certificate` last used a blob.

## Test Plan

CI for now, but will use this in following PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants