-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track the certified block that published a blob last #2156
Merged
ndr-ds
merged 1 commit into
main
from
06-18-track_the_certified_block_that_published_a_blob_last
Jun 20, 2024
Merged
Track the certified block that published a blob last #2156
ndr-ds
merged 1 commit into
main
from
06-18-track_the_certified_block_that_published_a_blob_last
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andresilva91 and the rest of your teammates on Graphite |
graphite-app
bot
requested review from
christos-h,
afck,
MathieuDutSik,
jvff,
ma2bd and
Twey
June 18, 2024 16:53
Graphite Automations"Assign reviewers" took an action on this PR • (06/18/24)6 reviewers were added to this PR based on Andre da Silva's automation. |
ma2bd
reviewed
Jun 18, 2024
afck
approved these changes
Jun 19, 2024
ndr-ds
force-pushed
the
06-18-track_the_certified_block_that_published_a_blob_last
branch
from
June 20, 2024 10:16
4d03523
to
38daae1
Compare
ndr-ds
force-pushed
the
06-18-track_the_certified_block_that_published_a_blob_last
branch
from
June 20, 2024 10:17
38daae1
to
6825d07
Compare
ndr-ds
force-pushed
the
06-18-track_the_certified_block_that_published_a_blob_last
branch
from
June 20, 2024 12:16
6825d07
to
a977ea2
Compare
ndr-ds
deleted the
06-18-track_the_certified_block_that_published_a_blob_last
branch
June 20, 2024 12:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For example, if we know a certain blob was published, and we try to use it, but some of the validators don't have it, we need to be able to know the certificate that last used the blob so that we can sync validators to also have that blob. That's one use case for this, but there are more. Part of #2033
Proposal
Track what
Certificate
last used the blob. As of right now, the only "usage" is publishing a blob, but in the future we'll also use it in theread_blob
system API call, when we replaceBytecode
with blobs, etc.Test Plan
CI + will use this in following PRs