Add unit test for saving wallet with pending blobs #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andresilva91 and the rest of your teammates on |
ndr-ds
force-pushed
the
10-22-add_unit_test_for_saving_wallet_with_pending_blobs
branch
from
6851b18
to
626545a
Compare
ndr-ds
force-pushed
the
10-22-stop_using_clientoptions_in_clientcontext_directly
branch
from
7d98ce6
to
f727975
Compare
ndr-ds
force-pushed
the
10-22-add_unit_test_for_saving_wallet_with_pending_blobs
branch
from
626545a
to
cd36336
Compare
ndr-ds
force-pushed
the
10-22-stop_using_clientoptions_in_clientcontext_directly
branch
from
f727975
to
b71383e
Compare
ndr-ds
force-pushed
the
10-22-add_unit_test_for_saving_wallet_with_pending_blobs
branch
from
cd36336
to
072e716
Compare
ndr-ds
changed the base branch from
10-22-stop_using_clientoptions_in_clientcontext_directly
to
graphite-base/2679
ndr-ds
force-pushed
the
10-22-add_unit_test_for_saving_wallet_with_pending_blobs
branch
from
072e716
to
d985546
Compare
ndr-ds
force-pushed
the
graphite-base/2679
branch
from
b71383e
to
6f44b9f
Compare
ndr-ds
force-pushed
the
10-22-add_unit_test_for_saving_wallet_with_pending_blobs
branch
from
d985546
to
648f7be
Compare
afck
approved these changes
Oct 23, 2024
linera-client/src/unit_tests/mod.rs
Outdated
Comment on lines
4
to
6
| #[cfg(test)] | ||
| mod util; | ||
|
|
||
| #[cfg(test)] | ||
| mod chain_listener; | ||
|
|
||
| #[cfg(test)] | ||
| mod wallet; |
There was a problem hiding this comment.
Isn't the whole module already cfg(test)?
Suggested change
| #[cfg(test)] | |
| mod util; | |
| #[cfg(test)] | |
| mod chain_listener; | |
| #[cfg(test)] | |
| mod wallet; | |
| mod util; | |
| mod chain_listener; | |
| mod wallet; |
There was a problem hiding this comment.
Good point 😅 Will fix
That's a great point 🤔 I went with it like this because I thought that we might as well test the full flow of saving a wallet with pending blobs, as that wasn't triggered by any other test it seems |
ndr-ds
force-pushed
the
10-22-add_unit_test_for_saving_wallet_with_pending_blobs
branch
from
648f7be
to
f060ff1
Compare
ma2bd
reviewed
Oct 23, 2024
linera-client/src/client_context.rs
Outdated
| @@ -185,6 +185,41 @@ where | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(with_testing)] | |||
| pub fn new_test(storage: S, wallet: W) -> Self { | |||
There was a problem hiding this comment.
{create,make,new}_test_client_context ?
There was a problem hiding this comment.
I thought the client_context suffix was redundant, since we're calling it from a ClientContext struct 🤔 but I can change it
ndr-ds
force-pushed
the
10-22-add_unit_test_for_saving_wallet_with_pending_blobs
branch
from
f060ff1
to
c5e6324
Compare
ndr-ds
force-pushed
the
10-22-add_unit_test_for_saving_wallet_with_pending_blobs
branch
from
c5e6324
to
3d43078
Compare
ndr-ds
deleted the
10-22-add_unit_test_for_saving_wallet_with_pending_blobs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CI was failing on PR #2646 with a JSON serialization failure. That was fixed by PR #2668 but we realized none of our tests covered this case.
Proposal
Create a test that tries to save a wallet with pending blobs in it. Verified that before #2668 this test fails, and now it succeeds.
Test Plan
CI
Release Plan