Make storage-service a default feature #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
force-pushed
the
storage_feature
branch
2 times, most recently
from
52b9966
to
b914454
Compare
afck
approved these changes
Oct 31, 2024
ma2bd
force-pushed
the
storage_feature
branch
from
b914454
to
f538658
Compare
afck
reviewed
Oct 31, 2024
| run: | | ||
| cargo test --features unstable-oracles --locked | ||
| # TODO(#2764): Actually link this to the default features | ||
| cargo test --no-default-features --features fs,macros,wasmer,rocksdb,unstable-oracles --locked |
There was a problem hiding this comment.
Ah, right!
Wasn't the plan to introduce a non-default test-storage-service feature? Then we could use the default features here without running those tests.
ma2bd
force-pushed
the
storage_feature
branch
from
f538658
to
9620b85
Compare
ma2bd
force-pushed
the
storage_feature
branch
from
9620b85
to
d1c23e3
Compare
ma2bd
added a commit
that referenced
this pull request
Nov 1, 2024
* make sure injecting the "test" feature does not always bring back the default features of a crate * Make storage-service a default feature * fix CI in a minimal way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Users should be able to use
linera net upaftercargo install linera-storage-service linera-service(without passing additional features).Proposal
Make
storage-servicea default featureCaveat:
cargo test -p linera-servicewill not pass anymore. Fixing this is a longer discussion (see e.g. #2699)Test Plan
CI
Release Plan
devnetbranch, thentestnetbranch, then