Remove blobs cache #2784
Merged
Remove blobs cache #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andresilva91 and the rest of your teammates on |
ndr-ds
force-pushed
the
11-01-remove_blobs_cache
branch
from
5119ff6
to
681ecdf
Compare
afck
approved these changes
Nov 2, 2024
afck
pushed a commit
to afck/linera-protocol
that referenced
this pull request
Nov 11, 2024
This cache isn't needed, and actually was incorrect in how we were using it: the cache wrongfully technically gave access to unpublished blobs to any chain in the client, as well as masked a bug (we needed to be checking the chain manager's pending blobs in `get_blobs` also). Remove the cache Existing ts in CI should pass and confirm that this indeed wasn't needed. I feel like this should probably be backported everywhere? - These changes should be backported to the latest `devnet` branch - These changes should be backported to the latest `testnet` branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This cache isn't needed, and actually was incorrect in how we were using it: the cache wrongfully technically gave access to unpublished blobs to any chain in the client, as well as masked a bug (we needed to be checking the chain manager's pending blobs in
get_blobsalso).Proposal
Remove the cache
Test Plan
Existing ts in CI should pass and confirm that this indeed wasn't needed.
Release Plan
I feel like this should probably be backported everywhere?
devnetbranchtestnetbranch