Split rust CI into more jobs #2786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
ea251d7
to
8eb09ba
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
3ffafd9
to
1f6268a
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
2 times, most recently
from
ee6d349
to
59cb85b
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
1f6268a
to
63f038c
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
59cb85b
to
bf5ab5c
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
63f038c
to
f0f704d
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
bf5ab5c
to
631364e
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
f0f704d
to
0f57c58
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
631364e
to
83c1944
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
0f57c58
to
4824098
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
83c1944
to
facd157
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
4824098
to
c68473d
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
facd157
to
99b8f1f
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
c68473d
to
3e17207
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
99b8f1f
to
e1af55b
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
3e17207
to
b3f5cf8
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
2 times, most recently
from
d30332c
to
8ed386a
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
b3f5cf8
to
2010c9e
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
8ed386a
to
0a8ccc4
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
2010c9e
to
f9fa551
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
2 times, most recently
from
6ff1a0f
to
47e4443
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
f9fa551
to
d4706f4
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
2 times, most recently
from
f862c21
to
dfa4908
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
d4706f4
to
83d1692
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
dfa4908
to
5450a3b
Compare
deuszx
reviewed
Nov 5, 2024
.github/workflows/rust.yml
Outdated
Comment on lines
85
to
88
| sudo rm -rf /usr/share/dotnet | ||
| sudo rm -rf /opt/ghc | ||
| sudo rm -rf "/usr/local/share/boost" | ||
| sudo rm -rf "$AGENT_TOOLSDIRECTORY" |
There was a problem hiding this comment.
This runs in parallel to the remote-net-tests and also has the "Clear up some space" step. Are you sure these parallel jobs, trying to access the same directories, won't conflict with each other? Do they run on separate machines?
There was a problem hiding this comment.
They all run in their own isolated VMs: https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#overview-of-github-hosted-runners
I also think these steps might be unnecessary now 🤔 Let me try removing them
deuszx
approved these changes
Nov 5, 2024
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
83d1692
to
792bc4c
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
5450a3b
to
f288c9f
Compare
ndr-ds
force-pushed
the
11-01-lint_has_been_silently_timing_out
branch
from
792bc4c
to
a5479f7
Compare
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
f288c9f
to
f1966ea
Compare
ndr-ds
changed the base branch from
11-01-lint_has_been_silently_timing_out
to
graphite-base/2786
ndr-ds
force-pushed
the
11-01-split_rust_ci_into_more_jobs
branch
from
f1966ea
to
b34213b
Compare
ma2bd
pushed a commit
that referenced
this pull request
Nov 11, 2024
## Motivation CI takes a long time ## Proposal Split into more jobs, which will make us do roughly the same amount of work, but more parallelized. So hopefully this reduces CI time without increasing github costs much. ## Test Plan CI With this and the PR before this one (#2785), we went from having the `test` job sometimes take up to an hour, to now, running many jobs in parallel, the test that takes the longest is `check-all-features`, which takes around 30 minutes. ## Release Plan - Nothing to do / These changes follow the usual release cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CI takes a long time
Proposal
Split into more jobs, which will make us do roughly the same amount of work, but more parallelized. So hopefully this reduces CI time without increasing github costs much.
Test Plan
CI
With this and the PR before this one (#2785), we went from having the
testjob sometimes take up to an hour, to now, running many jobs in parallel, the test that takes the longest ischeck-all-features, which takes around 30 minutes.Release Plan