ValidatorName->ValidatorPublicKey #2827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ndr-ds
force-pushed
the
11-06-validatorname-_validatorpublickey
branch
3 times, most recently
from
cb23746
to
d239f58
Compare
ndr-ds
requested review from
afck,
bart-linera,
christos-h,
deuszx,
jvff,
ma2bd,
MathieuDutSik and
Twey
deuszx
reviewed
Nov 6, 2024
Twey
previously approved these changes
Nov 6, 2024
ma2bd
requested changes
Nov 6, 2024
| @@ -11,7 +11,7 @@ use crate::test::{make_first_block, BlockTestExt}; | |||
| fn test_signed_values() { | |||
| let key1 = KeyPair::generate(); | |||
| let key2 = KeyPair::generate(); | |||
| let name1 = ValidatorName(key1.public()); | |||
| let name1 = ValidatorPublicKey(key1.public()); | |||
There was a problem hiding this comment.
These renamings are always work work because we forget places like here, the variable.
There was a problem hiding this comment.
My bad! Let me do a pass and see if I forgot anywhere else
ndr-ds
force-pushed
the
11-06-validatorname-_validatorpublickey
branch
2 times, most recently
from
8640ab0
to
5b738ea
Compare
ndr-ds
force-pushed
the
11-06-validatorname-_validatorpublickey
branch
from
5b738ea
to
7cfe386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ValidatorNameseems confusing, because we have actual names for validators now (azurenode,lavanderfive, etc), and this is not it. It's the public key of the validator.Proposal
Change
ValidatorNametoValidatorPublicKey.If you disagree with this, speak now or forever hold your peace :)
Fixes #2820
Test Plan
CI
Release Plan