Unify HashedCertificateValue with Hashed<T> #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
reviewed
Nov 11, 2024
afck
approved these changes
Nov 11, 2024
deuszx
force-pushed
the
timeout-certificate
branch
from
437ace7
to
3fd347a
Compare
deuszx
force-pushed
the
unify-hashed-types
branch
from
25b18e0
to
9608162
Compare
deuszx
force-pushed
the
timeout-certificate
branch
from
3fd347a
to
fe66e51
Compare
deuszx
force-pushed
the
unify-hashed-types
branch
from
9608162
to
7025c92
Compare
deuszx
force-pushed
the
unify-hashed-types
branch
from
7025c92
to
b09603d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the process of adding separate types to discriminate between various types of certificate we have, a new generic type was introduct -
Hashed<T>. That type had the same structure as already-existingHashedCertificateValuebut it was generic of a value type it holds. This duplication was unnecessary.Proposal
Replace a
struct HashedCertificateValuewith a type aliastype HashedCertificateValue = Hashed<CertificateValue>Test Plan
CI should catch any regressions.
Release Plan
Links
Closes #2842