Read confirmed certs #2867
Merged
Read confirmed certs #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deuszx
commented
Nov 12, 2024
| // The certificate is not as expected. Give up. | ||
| warn!("Failed to process network certificate {}", hash); | ||
| return info; | ||
| } | ||
| let mut result = self.handle_certificate(certificate.clone(), vec![]).await; | ||
| let mut result = self | ||
| .handle_certificate(certificate.clone().into(), vec![]) |
There was a problem hiding this comment.
handle_certificate expects the "old" Certificate type still. Internally it pattern-matches on the value type (ConfirmedValue enum) and forwards to the specialized handlers.
deuszx
commented
Nov 12, 2024
afck
reviewed
Nov 12, 2024
deuszx
force-pushed
the
read-confirmed-certs
branch
from
f1d9287
to
689104f
Compare
afck
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We know that in storage we only ever have instances of confirmed certificates.
Proposal
Reflect that fact in the API of the
Storage.Test Plan
Release Plan
Links
Closes #2860