Use hex_debug, skip_if and custom_derive_debug where appropriate.
#2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deuszx
approved these changes
Nov 13, 2024
ma2bd
reviewed
Nov 15, 2024
| @@ -332,120 +348,10 @@ where | |||
| } | |||
| } | |||
|
|
|||
| impl<Context> Debug for ChainWorkerRequest<Context> | |||
There was a problem hiding this comment.
@afck Thank you so much for removing all this boiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our debug logs are very noisy because some
Vec<u8>s are printed using the standard derivedDebug, and they print every field, even ones that are e.g. only interesting if they areSome. We also have several hand-writtenDebugimpls that could be derived.Proposal
Use
hex_debug,skip_ifandcustom_debug_derivewhere appropriate.Test Plan
This doesn't change the logic; CI should catch any regressions. If we notice that debug output is still too noisy we can make further changes in the future.
Release Plan
Links