Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize Vote and SignatureAggregator over type of value they hold. #2887

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Generalize Vote and SignatureAggregator over type of value they hold. #2887

merged 7 commits into from
Nov 15, 2024
+142 −64

Commits on Nov 13, 2024

  1. SignatureAggregator over GenericCertificate

    @deuszx
    deuszx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    99042b8 View commit details
    Browse the repository at this point in the history

  2. Vote is generic over value it contains

    @deuszx
    deuszx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7ecabc9 View commit details
    Browse the repository at this point in the history

  3. Use actual Timeout type in ChainManager instead

    @deuszx
    deuszx committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a1e3418 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Replace From with TryFrom

    @deuszx
    deuszx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    bdbad2f View commit details
    Browse the repository at this point in the history

  2. Replace TODO with a comment.

    @deuszx
    deuszx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    dcf0a66 View commit details
    Browse the repository at this point in the history

  3. Replace hand-written Deserialize for Vote with derive

    @deuszx
    deuszx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b4e8e64 View commit details
    Browse the repository at this point in the history

  4. Simplify call to extract ChainId

    @deuszx
    deuszx committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    07bb76a View commit details
    Browse the repository at this point in the history