client_for_proxy_worker -> worker_client #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-ds
requested review from
afck,
bart-linera,
christos-h,
deuszx,
jvff,
ma2bd,
MathieuDutSik and
Twey
jvff
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A lot of the code around this function changed, and I think we forgot to also update the name
Proposal
Change it from
client_for_proxy_workertoworker_client. This is already insideGrpcProxy, so I think havingproxyin the name is redundant. The name of the struct that this returns isValidatorWorkerClient, soworker_clientseemed to make the most sense.I think (IMHO) this makes it a lot easier to understand what this function is returning.
Test Plan
CI
Release Plan