Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unexpected blob id in replication #2932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justinlin-linkedin
Copy link
Collaborator

Summary

Add a configuration to ignore unexpected blob id in replication thread. It's safe to do so because these blob ids don't belong to the partition anyway, we should just ignore it.

Test

no tests added

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.25%. Comparing base (52ba813) to head (c9090da).
Report is 133 commits behind head on master.

Files with missing lines Patch % Lines
...va/com/github/ambry/replication/ReplicaThread.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2932      +/-   ##
============================================
+ Coverage     64.24%   70.25%   +6.01%     
- Complexity    10398    11986    +1588     
============================================
  Files           840      865      +25     
  Lines         71755    73666    +1911     
  Branches       8611     8863     +252     
============================================
+ Hits          46099    51757    +5658     
+ Misses        23004    19220    -3784     
- Partials       2652     2689      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants