system-status: db: reverse order #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list we get from the DB is reversed, to be able to easily limit it to 40 entries. To present the data in the right order in the JSON, we need to reverse them again. The UI could also reverse them, but it sounds better to write the data in the right order instead. Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
kuba-moo
reviewed
Jun 12, 2024
| @@ -180,7 +180,7 @@ def add_db(result, cfg): | |||
|
|
|||
| with psql.cursor() as cur: | |||
| cur.execute(f"SELECT ts,size FROM {tbl} ORDER BY id DESC LIMIT 40") | |||
There was a problem hiding this comment.
Just remove the DESC here, no?
There was a problem hiding this comment.
Yes, but then it will take the 40 first ones, instead of the 40 last ones. If you want the last 40 ones in the right order, you need to use an offset, which cannot be negative, etc. :) (or maybe they have a new attribute?)
I found it easier and clearer to do it like that (but I forgot the reverse...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list we get from the DB is reversed, to be able to easily limit it to 40 entries. To present the data in the right order in the JSON, we need to reverse them again.
The UI could also reverse them, but it sounds better to write the data in the right order instead.