Fix SSH execution not redirecting output properly #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch aims to save commands stdout/stderr once they are executed inside the SSH channel. The whole implementation has been changed, in order to customize the current SSH session object and to store both stdout and stderr messages inside it, as well as checking for Kernel Panic triggered by the command. In this way, the whole SSH implementation should be also more stable. Also, SSH tests have been improved by adding more tests, in order to check stderr acquisition and long stdout text messages.
The previous code was not taking in consideration the return code 0, so when test text was not acquired correctly, the text process ended up to recognize test failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to save commands stdout/stderr once they are executed inside the SSH channel. The whole implementation has been changed, in order to customize the current SSH session object and to store both stdout and stderr messages inside it, as well as checking for Kernel Panic triggered by the command. In this way, the whole SSH implementation should be also more stable.
Also, SSH tests have been improved by adding more tests, in order to check stderr acquisition and long stdout text messages.