Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the problem of obtaining the path of the boot menu theme #1736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swq11
Copy link
Contributor

@swq11 swq11 commented Oct 12, 2024

Log: Get the image path through the backend

Task: https://pms.uniontech.com/task-view-364169.html

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swq11

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. CommonInfoWork::active()函数中,m_commomModel拼写错误,应为m_commonModel
  2. CommonInfoWork::getPlymouthFilePixmap()函数被删除,但未在代码的其他部分找到相应的调用,如果该函数在其他地方被调用,则需要确认是否已删除。
  3. BootPage.qml文件中,source属性使用了dccData.mode().grubThemePath,但没有处理路径不存在的情况,可能会导致应用程序崩溃。
  4. main.qml文件中,visible属性使用了!dccData.mode().isCommunitySystem(),但没有处理isCommunitySystem()返回false的情况,可能会导致界面显示错误。
  5. CommonInfoModel类中的Q_PROPERTY声明使用了FINAL关键字,这可能会限制类的继承,除非有特殊需求,否则应移除FINAL关键字。
  6. CommonInfoModel类中的setGrubThemePath函数在设置新路径后触发了grubThemePathChanged信号,但没有在grubThemePathChanged信号的槽函数中更新UI,可能会导致UI与数据不一致。
  7. CommonInfoModel类中的grubThemePath属性和setGrubThemePath函数的命名不符合Qt的命名约定,建议使用驼峰命名法,如grubThemePath改为grubThemePathsetGrubThemePath改为setGrubThemePath
  8. CommonInfoModel类中的grubThemePathChanged信号命名不符合Qt的命名约定,建议使用GrubThemePathChanged
  9. CommonInfoModel类中的m_grubThemePath成员变量命名不符合Qt的命名约定,建议使用m_grubThemePath
  10. CommonInfoModel类中的Q_PROPERTY声明使用了FINAL关键字,这可能会限制类的继承,除非有特殊需求,否则应移除FINAL关键字。

综上所述,代码中存在一些命名规范和逻辑问题,建议进行修改以符合Qt的编程规范和最佳实践。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants