csd-wacom: remove ifdef code that cannot compile #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression in commit 88e9de5. This was probably a bad merge from gnome. The HAVE_WAYLAND define is never defined, but if it did then the code would try to include a cinnamon header that has never existed, then call a gnome-settings-daemon internal function that does not exist. It is possible to properly implement HAVE_WAYLAND, but this code didn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression in commit 88e9de5. This was probably a bad merge from gnome. The HAVE_WAYLAND define is never defined, but if it did then the code would try to include a cinnamon header that has never existed, then call a gnome-settings-daemon internal function that does not exist.
It is possible to properly implement HAVE_WAYLAND, but this code didn't.