Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add option to enable onscreen keyboard #62

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jakko3
Copy link

@Jakko3 Jakko3 commented Dec 21, 2023

Fixes: #59

I haven't considered translations. How is the procedure about them?

Marking as draft because the PR depends on slick-greeter PR linuxmint/slick-greeter#229.

@Jakko3
Copy link
Author

Jakko3 commented Dec 21, 2023

Actually this new switch "On-screen keyboard" and the aldready existing selection list "On-screen keyboard" are in a section called "Panel indicators".

switch_onscreen_keyboard

It would be better to create a new section "On-screen keyboard" above section "Panel indicators" and move the new switch and the existing layout selection list there.

@Jakko3
Copy link
Author

Jakko3 commented Dec 21, 2023

Moved new switch and layout list into a new section "On-screen keyboard". The diff looks a bit confusing now – for the settings window, however, it makes sense:

section_onscreen_keyboard

@Jakko3
Copy link
Author

Jakko3 commented Dec 21, 2023

Removed the the related issue number #59 from the commit message because this emitted a message to this issue every time a change was done to the commit.

@Jakko3 Jakko3 changed the title Add option to enable onscreen keyboard (#59) Add option to enable onscreen keyboard Dec 21, 2023
Move the layout selection list for the onscreen keyboard out of the section
"Panel indicators" into a new section "On-screen keyboard". Because it doesn't
act on the panel indicators, instead it acts on the onscreen keyboard.
@Jakko3
Copy link
Author

Jakko3 commented Dec 22, 2023

For better readability of the diffs I split the changes into two separate commits: first create a new section for onscreen keyboard, then add the option to enable it.

@Jakko3
Copy link
Author

Jakko3 commented Dec 22, 2023

A comment on the pictures, the default is onscreen keyboard off and layout "Small":

default_onscreen_keyboard

@clefebvre clefebvre changed the title Add option to enable onscreen keyboard [WIP] Add option to enable onscreen keyboard Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Switch to enable onscreen keyboard
1 participant