Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detection #417

Closed
wants to merge 1 commit into from
Closed

Update detection #417

wants to merge 1 commit into from

Conversation

nemchik
Copy link
Member

@nemchik nemchik commented Oct 4, 2023

backwards compatible in case the output reverts

@nemchik
Update rdetection
b8242e4 
backwards compatible in case the output reverts
@nemchik nemchik requested a review from a team October 4, 2023 01:04
@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/swag/2.7.0-pkg-5e0cdeca-dev-b8242e4959e2e8d7c8db52449124a5c4d6a11c12-pr-417/index.html
https://ci-tests.linuxserver.io/lspipepr/swag/2.7.0-pkg-5e0cdeca-dev-b8242e4959e2e8d7c8db52449124a5c4d6a11c12-pr-417/shellcheck-result.xml

Tag Passed
amd64-2.7.0-pkg-5e0cdeca-dev-b8242e4959e2e8d7c8db52449124a5c4d6a11c12-pr-417 ✅
arm64v8-2.7.0-pkg-5e0cdeca-dev-b8242e4959e2e8d7c8db52449124a5c4d6a11c12-pr-417 ✅

@nemchik nemchik changed the title Update rdetection Update detection Oct 4, 2023
Roxedus
Roxedus reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@Roxedus Roxedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be dependent on the entrypoint and name being the same, which currently is the same.

@nemchik
Copy link
Member Author

nemchik commented Oct 5, 2023

This seems to be dependent on the entrypoint and name being the same, which currently is the same.

This is true. I don't know if there is a strict requirement in place for these to match. The entrypoint sounds like the better option to use, but the format output change has me cautious about using it.

@Roxedus
Copy link
Member

Roxedus commented Oct 6, 2023

I looked a bit into the entrypoint, and it seems plausible it is referencing pypa entrypoints, which probably isnt changing in the future. https://github.com/certbot/certbot/blob/master/certbot/certbot/_internal/plugins/disco.py#L178

@nemchik
Copy link
Member Author

nemchik commented Oct 6, 2023

I looked a bit into the entrypoint, and it seems plausible it is referencing pypa entrypoints, which probably isnt changing in the future. https://github.com/certbot/certbot/blob/master/certbot/certbot/_internal/plugins/disco.py#L178

that looks very promising.

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2024

This pull request is locked due to inactivity

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
@nemchik nemchik deleted the nemchik-patch-1 branch February 4, 2024 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Roxedus Roxedus Roxedus left review comments

Assignees
No one assigned
Labels
closed-pr-activity no-pr-activity
Projects
Issue & PR Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nemchik @LinuxServer-CI @Roxedus