Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network: firewall controller webhook uniqe table name #2193

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Network: firewall controller webhook uniqe table name #2193

merged 1 commit into from
Dec 12, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Dec 6, 2023 •
edited
Loading

Description

This PR fixes a bug in webhook validation for firewall configuration table names

It depends on #2174

@cheina97 cheina97 added the kind/bug Something isn't working label Dec 6, 2023
@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

cheina97 commented Dec 6, 2023

/build

@cheina97
Copy link
Member Author

cheina97 commented Dec 6, 2023

/hold

@adamjensenbot adamjensenbot added the hold Prevent bot merging label Dec 6, 2023
@cheina97 cheina97 added the kind/feature New feature or request label Dec 6, 2023
@cheina97
Copy link
Member Author

cheina97 commented Dec 6, 2023

/build

@cheina97 cheina97 force-pushed the frc/fwcfgwebhookfix branch 2 times, most recently from e46e10a to 9379227 Compare December 6, 2023 11:58
@cheina97
Copy link
Member Author

cheina97 commented Dec 6, 2023

/unhold

@adamjensenbot adamjensenbot removed the hold Prevent bot merging label Dec 6, 2023
@cheina97 cheina97 removed the kind/feature New feature or request label Dec 6, 2023
@cheina97
Copy link
Member Author

cheina97 commented Dec 7, 2023

/build

@cheina97
Copy link
Member Author

cheina97 commented Dec 7, 2023

/build

@cheina97 cheina97 force-pushed the frc/fwcfgwebhookfix branch 3 times, most recently from 5f65f65 to 05ab5fb Compare December 11, 2023 16:59
@cheina97 cheina97 merged commit b2eefea into liqotech:network-external Dec 12, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheina97 @adamjensenbot @aleoli