Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Network: PodCIDR, ServiceCIDR, ExternalCIDR, ReservedCIDRs as Networks #2199

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Dec 7, 2023

Description

This PR changes the management of pod CIDR, service CIDR, external CIDR, and reserved CIDRs. These are created at install time as Network resources (from the new IPAM API).
Thanks to this mechanism, it is now possible to choose the external CIDR at install time (if conflicts are found with other pre-allocated networks, the IPAM is used to obtain a remapped network CIDR).

Additional changes:

  • added utility functions to retrieve cluster parameters (such as pod CIDR, service CIDR, etc..) using the Network API (without relying on the IpamStorage).
  • added readiness and liveness probes to the gRPC server of the IPAM pod

@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 changed the title IPAM: Networks refactoring External Network: IPAM: Networks refactoring Dec 7, 2023
@cheina97 cheina97 force-pushed the network-external branch 7 times, most recently from fa2396a to 888437f Compare December 12, 2023 14:10
@fra98 fra98 force-pushed the frt/configurations-ipam branch 5 times, most recently from 4d2674a to e9ac87d Compare December 14, 2023 12:11
@fra98 fra98 changed the title External Network: IPAM: Networks refactoring External Network: PodCIDR, ServiceCIDR, ExternalCIDR, ReservedCIDRs as Networks Dec 14, 2023
@fra98 fra98 marked this pull request as ready for review December 14, 2023 14:07
cmd/ipam/main.go Outdated Show resolved Hide resolved
deployments/liqo/templates/liqo-ipam-deployment.yaml Outdated Show resolved Hide resolved
deployments/liqo/templates/liqo-ipam-service.yaml Outdated Show resolved Hide resolved
pkg/utils/ipam/networks.go Outdated Show resolved Hide resolved
pkg/utils/ipam/networks.go Outdated Show resolved Hide resolved
@fra98 fra98 force-pushed the frt/configurations-ipam branch 3 times, most recently from 3216c42 to 268dd7d Compare December 18, 2023 12:04
@fra98 fra98 merged commit ca27c28 into liqotech:network-external Dec 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants